Fix Windows dissector install instructions#11
Fix Windows dissector install instructions#11tablackburn wants to merge 1 commit intochrisle:mainfrom
Conversation
The plugins directory does not exist by default on Windows. Updated the Windows instructions to create it first (matching the macOS/Linux instructions) and added commands for both Command Prompt and PowerShell since %APPDATA% expansion differs between shells. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Windows Wireshark dissector installation docs so they work on fresh installs by creating the plugins directory and providing shell-specific commands.
Changes:
- Add Command Prompt instructions that create
%APPDATA%\Wireshark\pluginsbefore copying - Add PowerShell equivalents using
$env:APPDATAandNew-Item - Replace the previous “copy to this path” text with executable command snippets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mkdir "%APPDATA%\Wireshark\plugins" | ||
| copy stagelinq.lua "%APPDATA%\Wireshark\plugins\" |
There was a problem hiding this comment.
copy will prompt on overwrite in some scenarios, and mkdir will emit an “already exists” message when re-running the instructions. Consider making the Command Prompt steps explicitly idempotent (e.g., guard the mkdir with if not exist ... and use copy /Y if overwriting is acceptable) to avoid interactive prompts and reduce confusion when users rerun the steps.
| mkdir "%APPDATA%\Wireshark\plugins" | |
| copy stagelinq.lua "%APPDATA%\Wireshark\plugins\" | |
| if not exist "%APPDATA%\Wireshark\plugins" mkdir "%APPDATA%\Wireshark\plugins" | |
| copy /Y stagelinq.lua "%APPDATA%\Wireshark\plugins\" |
| New-Item -ItemType Directory -Force -Path "$env:APPDATA\Wireshark\plugins" | ||
| Copy-Item stagelinq.lua "$env:APPDATA\Wireshark\plugins\" |
There was a problem hiding this comment.
New-Item will print an object to the console by default, which can be distracting in copy/paste instructions. Consider suppressing that output (e.g., piping to Out-Null) to keep the instructions cleaner; similarly, if overwriting an existing stagelinq.lua is expected, consider using Copy-Item -Force to avoid prompts/errors.
| New-Item -ItemType Directory -Force -Path "$env:APPDATA\Wireshark\plugins" | |
| Copy-Item stagelinq.lua "$env:APPDATA\Wireshark\plugins\" | |
| New-Item -ItemType Directory -Force -Path "$env:APPDATA\Wireshark\plugins" | Out-Null | |
| Copy-Item stagelinq.lua "$env:APPDATA\Wireshark\plugins\" -Force |
Summary
%APPDATA%\Wireshark\plugins\directory does not exist by default on Windows, so the current instructions failmkdirstep to match the macOS/Linux instructions%APPDATA%expansion differs between shellsTest plan
🤖 Generated with Claude Code